Skip to content

Kelli Hanson- User-Interface-Project-Week #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 83 commits into
base: master
Choose a base branch
from

Conversation

kelliraehanson
Copy link

Copy link

@decagondev decagondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

Kelly. Your code and html markup looks clean and your desktop view of the home page is looking almost pixel near enough when viewed on a smallish screen. when i view it at full screen all of the elements are off. But your mobile view is not working on mobile. Which is due to the view-port tags not being set. So mobile views think that the viewport is full screen. It seems that you have not met full mvp for this project.

Breakdown

  • home page desktop view done
  • burger nav functional
  • desktop styles for home page almost pixel near enough
  • desktop styles on services page
  • services tab functionality working.

conclusions

Kelly it seems that you grasp the concepts of the design and development process. And the code you have provided is well formed. But the lack of content and the missing style features is hindering your mvp completeness Your git workflow seems to have good regularly and granularity. The only thing u can put mobile issues down to is either you have some changes that you have yet to push. Or your time management has caused your project to suffer or lack of research. I have tested all desktop breakpoints on pc and mac and also several mobile devices. The breakpoints are there but the css is off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants