-
Notifications
You must be signed in to change notification settings - Fork 141
Fix: Miscellaneous Clang warnings #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pniedzielski
merged 9 commits into
bloomberg:main
from
pniedzielski:published/fix/warnings/misc
Jul 8, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
399fa1b
Fix: Disable self-assignment warning in test
pniedzielski 654a46b
Fix: Change unintentional HTML usage in docs
pniedzielski 86b6f74
Fix: Replace old-style casts with `static_cast`
pniedzielski 71ad230
Fix: Avoid missing prototype warning in tests
pniedzielski 2d3db89
Fix: Fix member template class destructor name
pniedzielski ca7969c
Fix: Weak vtable pointer warning
pniedzielski b01ea97
Fix: Properly scope bmqstoragetool `typedef`s
pniedzielski d5a0d53
Fix: Avoid name shadowing
pniedzielski 3fd7c7f
Fix: Replace old-style casts with `static_cast`
pniedzielski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
748 changes: 429 additions & 319 deletions
748
src/applications/bmqstoragetool/m_bmqstoragetool_cslprinter.cpp
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this syntax doesn't compile on C++03, I believe I've been burned by this before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give this a shot in C++03 then; if it doesn't compile, we'll have to turn that warning off.
I see in the git log that we also tried:
which also doesn't compile in C++03.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need this to compile in C++03: the storage tool is written in C++11, and won't compile in C++03. But our check for this only makes sure that we're not building on Solaris: building
all
in C++03 on Linux will fail with some C++11-isms in the storage tool. I'll fix the check to make sureCMAKE_CXX_STANDARD
is C++11 or better.But either way, clang doesn't complain about this line in C++03.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we solve this issue completely by placing the nested class declaration to the outer scope?