Fix: Clang warnings related to signed-unsigned conversions #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds two explicit casts to the `put` function of both `FileBackedStorage` and `InMemoryStorage`, silencing warnings from Clang, and making it explicit that we have a type boundary between one interface that provides us with a signed `int`, and another that provides us with an `unsigned int`. A cursory examination of both of these interfaces does not give a clear answer to whether we can (or should) change their type; instead we make explicit the unsafe type-conversion behavior here. Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch fixes the last of the signed-unsigned comparison warnings in our unit tests. We mostly do this by changing the types that are being compared, rather than introducing new casts. However, when we need to introduce a new cast, we choose to cast the reference value we are comparing to, rather than the return value from the component-under-test. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
published/fix/warnings/signed-unsigned
branch
from
9a4182e to
e392bf0
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
This patch removes two asserts from the `bmqa_message` unit test that are now trivially true due to the previous warning fixes. One is a nonnegative check that is now trivially true by virtue of the type now being unsigned; one is a postcondition check that is necessarily true now. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
published/fix/warnings/signed-unsigned
branch
from
e392bf0 to
d5e6b4a
Compare
678098
approved these changes
Jun 17, 2025
hallfox
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings that Clang emits due to signed-unsigned conversions.
Please see commit messages for more details.