Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate tutorial #20

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Translate tutorial #20

merged 4 commits into from
Mar 24, 2021

Conversation

dylankiss
Copy link
Collaborator

No description provided.

@dylankiss
Copy link
Collaborator Author

Pagina is vertaald, maar er loopt iets mis bij het genereren van die specifieke pagina. Ik krijg telkens de error:

Failed to compile

./pages/docs/tutorial.mdx
TypeError: Cannot read property 'replace' of undefined
    at Array.map (<anonymous>)

maar geen idee vanwaar die komt.

@dylankiss dylankiss marked this pull request as ready for review March 11, 2021 13:16
@dylankiss dylankiss requested a review from LoriKarikari March 11, 2021 13:16
LoriKarikari
LoriKarikari reviewed Mar 23, 2021
View reviewed changes
app/pages/docs/tutorial.mdx Outdated
create it". This is perfect for this case because we didn't require the
user to add three choices when creating the question. So if later the user
adds another choice by editing the question, then it'll be created here.
is een speciale operatie die betekent: "Als dit item bestaat, update het
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is een speciale operatie die betekent: "Als dit item bestaat, update het
is een speciale handeling die betekent: "Als dit item bestaat, update het

Leek mij duidelijker in deze context. Operatie doet me meer aan de ziekenhuisbehandeling denken.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misschien hier database operatie van maken? De term operatie wordt in deze context wel gebruikt in onze sector natuurlijk. Handeling vind ik wat vreemder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja databaseoperatie is nog beter. Ben niet zeker van de spatie. Beide variaties worden blijkbaar gebruikt.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google wilt "databaseoperatie" altijd veranderen naar "database operatie" 😄 Ik vind het af elkaar nog iets duidelijker om te lezen. Een samenstelling met twee klinkers tegen elkaar vind ik er vaak wat moeilijk uitzien.

@dylankiss dylankiss force-pushed the translate-tutorial branch from 4bb3d05 to c2d45a8 Compare March 23, 2021 21:00
@dylankiss dylankiss merged commit 4a7583d into main Mar 24, 2021
@dylankiss dylankiss deleted the translate-tutorial branch March 24, 2021 16:14
@dylankiss dylankiss mentioned this pull request Mar 25, 2021
Open
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoriKarikari LoriKarikari LoriKarikari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylankiss @LoriKarikari