Face Library: Only handle click on card when selection mode is ongoing #17493
Conversation
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for this commit! This did fix the box popping up on but it may have regressed the details page functionality. Right now clicking on a face doesn't even show the details box anymore and I've tried this on other browsers and even in incognito mode to ensure no caching is causing it. |
|
I am not able to reproduce this, are you clicking on the image? keep in mind this is only for the train tab not the individual persons tab |
So it's even weirder! Some events show the details and some don't! I had a couple of events generated after the patch applied and some before the patch. There is a mixture of ones that work or don't work regardless of patch application. When I look at dev tools I don't see any errors EXCEPT when clicking on one that works and clicking off the details page to go back to the face page. Other than that DEV console is clean. |
|
perhaps a face was detected but an event wasn't saved |
Even further narrowing down has shown that if the Face is "UNKNOWN" none of the detail boxes work but if the face is known and grouped together all those pictures show the dialog box. So in this example:
All the ones grouped together with the known person name all works. However the ones in the group of Unknown none of them work even the ones where the name guess is good and even the unknown one. |
|
unknown works for me as well, if I had to guess this just means the second one does not have an event saved |
|
Ok, thanks for the feedback. I can monitor it. |
Type of change
Checklist
enlocale.ruff format frigate)