Skip to content

Fix renaming exports bug #16588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix renaming exports bug #16588

merged 1 commit into from
Feb 15, 2025

Conversation

hawkeye217
Copy link
Collaborator

Proposed change

When the name of an export had a slash in it, the api returned 404. This PR fixes the bug by moving the patch request to the body rather than the url.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 270563b
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/67afc1e496f93600086b9620
😎 Deploy Preview https://deploy-preview-16588--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 merged commit 6bb1a5d into dev Feb 15, 2025
12 checks passed
@NickM-27 NickM-27 deleted the fix-rename-export-bug branch February 15, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Renaming exports fails with 404 error when new name contains a slash
2 participants