-
-
Notifications
You must be signed in to change notification settings - Fork 694
Add dnsdmarc module, address #1626 #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
colin-stubbs
wants to merge
4,739
commits into
blacklanternsecurity:dev
Choose a base branch
from
colin-stubbs:dnsdmarc
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y/excavate-intercept Misc Bugfixes
…y/dnn-installwizard-bug DNN installwizard detector bugfix
…y/badsecrets-customsecrets-tweak better handling of custom secrets files
…y/update-trufflehog Update trufflehog to 3.82.11
…y/yara-handle-bad-chars handle bad chars in matched data
…y/shodan-pagination Misc improvements
…y/generic-ssrf-fix Fixing Bugs with Generic SSRF Payload
…y/fix-preset-bug Fix bug with module exclusions
…y/excavate-intercept Break out docs updater into separate workflow
…y/dev Dev --> Stable (2.1.0)
…y/update-docs Daily Docs Update
Use Safe Defaults for `lxml` Parsers
I noticed this change here: blacklanternsecurity@02acd94#diff-c6756c35a5fb1d7b87dc0ed3d33a2d211374dc196f245d26a362c82c8c346d5cR131 I can only assume it was unintentional, given `id` is a python builtin function, and `str(id)` returns: ```py cmyui@Joshs-MacBook-Pro ~ % python3 Python 3.13.0 (main, Oct 7 2024, 05:02:14) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> str(id) '<built-in function id>' ```
Fix preservation of scan id at scan init
…y/fix-extractous Update Extractous with new API changes
…y/dev Dev -> Stable 2.2.0
…y/bump-version Bump version
…y/dev Dev -> Stable Version Bump
Merged
@colin-stubbs nice work on this module. Also thanks for commenting and providing all those examples. I think it's safe to say you went deeper on DMARC than we typically do at BLS (our approach is to yeet a spoofed email and see if it lands 😂). A couple things:
Thoughts? |
nareshrajkumar866
approved these changes
May 22, 2025
nareshrajkumar866
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dnsdmarc module, refer to #1626 for more info.
Addresses #1626, partial relevance to #1682
I feel this needs some review, particularly for the VULNERABILITY events that are emitted.
e.g.
For anyone reviewing, the following domains and sample scan outputs/events are worth considering.
Sample scans/events,
apple.com, RUA+RUF email addresses, no vulnerabilities.
mastodon.social, RUA email only, sub-domains likely vulnerable to spoofing in some way,
mastodon.com ( a common mistake when trying to get to mastodon's web presence and what I'd use if I wanted to appear to be sending emails from "Mastodon" ;-) ), no DMARC policy, spoofability limited only by SPF.
33across.com - totally default "report-only" policy except there's no RUA or RUF destination provided.
adriver.ru - wildcard TXT responses are also returned, dnsdmarc module correctly ignores them for anything other than RAW_DNS_RECORD events.
w55c.net - RFC non-compliant DMARC policy due to v=DMARC; instead of v=DMARC1; and extra " at end of TXT content.
onenote.net - wildcard SPF TXT response only, no DMARC policy.
themoviedb.org - totally invalid TXT/CNAME configuration...
webex.com - partial (in fact zero) enforcement,
richaudience.com - invalid policy action due to typeo,
Sample SIEM-friendly JSON event,
Another one,