-
Notifications
You must be signed in to change notification settings - Fork 4
Add new split forms to reorganized Split & Multi-Step category #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
Username: "username", | ||
Email: "email", | ||
Password: "password", | ||
NewPassword: "new-password", |
Check warning
Code scanning / Checkmarx One
Use Of Hardcoded Password Medium
Username: "username", | ||
Email: "email", | ||
Password: "password", | ||
NewPassword: "new-password", | ||
CurrentPassword: "current-password", |
Check warning
Code scanning / Checkmarx One
Use Of Hardcoded Password Medium
Username: "username", | ||
Email: "email", | ||
Password: "password", | ||
NewPassword: "new-password", | ||
CurrentPassword: "current-password", | ||
ConfirmPassword: "confirm-password", |
Check warning
Code scanning / Checkmarx One
Use Of Hardcoded Password Medium
🎟️ Tracking
PM-19867
📔 Objective
Adds the following forms for testing:
Additionally, moves multi-step forms to a new category alongside these split forms, as the growing Login sidebar category tends to go off screen on a default browser/monitor resolution.
❓ This also adds what may be a QoL feature: auto-collapsing other sidebar categories while one is active. This may be rolled back if it interferes with automated testing or other usability concerns.
🎨 Finally, the form steps argument now also accepts an array of form steps as an individual step, meaning multiple inputs can be rendered on a single step by passing two types simultaneously, for example on split account creation:
📸 Screenshots
Screen.Recording.2025-06-23.at.11.09.12.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes