Skip to content

Add new split forms to reorganized Split & Multi-Step category #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blackwood
Copy link
Contributor

@blackwood blackwood commented Jun 23, 2025

🎟️ Tracking

PM-19867

📔 Objective

Adds the following forms for testing:

Split account creation

Page 1: email
Page 2: set password + confirm password

Split Change password:

Page 1: Current password
Page 2: New password

Additionally, moves multi-step forms to a new category alongside these split forms, as the growing Login sidebar category tends to go off screen on a default browser/monitor resolution.

❓ This also adds what may be a QoL feature: auto-collapsing other sidebar categories while one is active. This may be rolled back if it interferes with automated testing or other usability concerns.

🎨 Finally, the form steps argument now also accepts an array of form steps as an individual step, meaning multiple inputs can be rendered on a single step by passing two types simultaneously, for example on split account creation:

      <LoginForm
        action="/login"
        formSteps={[
          FormStep.Email,
          [FormStep.Password, FormStep.ConfirmPassword],
        ]}
      />

📸 Screenshots

Screen.Recording.2025-06-23.at.11.09.12.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@blackwood blackwood requested a review from a team as a code owner June 23, 2025 15:17
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

Copy link

Logo
Checkmarx One – Scan Summary & Details39908cb8-9645-41e6-a5f3-2cc3f01dd493

New Issues (4)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-30360 Npm-webpack-dev-server-4.15.2
detailsRecommended version: 5.2.1
Description: Webpack-dev-server allows users to use webpack with a development server that provides live reloading. Webpack-dev-server users' source code may b...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: KWmki%2BqAEFaVPF0p%2BOKVDi6kAGlhU096j8PPFElobzs%3D
Vulnerable Package
MEDIUM Use_Of_Hardcoded_Password /client/src/components/LoginForm.tsx: 27
detailsThe application uses the hard-coded password "confirm-password" for authentication purposes, either using it to verify users' identities, or to a...
ID: dreA08ZseC8MOuB4VTaSgXFTncw%3D
Attack Vector
MEDIUM Use_Of_Hardcoded_Password /client/src/components/LoginForm.tsx: 26
detailsThe application uses the hard-coded password "current-password" for authentication purposes, either using it to verify users' identities, or to a...
ID: oB1r1KPkZjcIEW3RtiKcMdwH69M%3D
Attack Vector
MEDIUM Use_Of_Hardcoded_Password /client/src/components/LoginForm.tsx: 25
detailsThe application uses the hard-coded password "new-password" for authentication purposes, either using it to verify users' identities, or to acces...
ID: QvPDUbdld5lGh8qlKzRfQeZdmFI%3D
Attack Vector

Username: "username",
Email: "email",
Password: "password",
NewPassword: "new-password",

Check warning

Code scanning / Checkmarx One

Use Of Hardcoded Password Medium

Use Of Hardcoded Password
Username: "username",
Email: "email",
Password: "password",
NewPassword: "new-password",
CurrentPassword: "current-password",

Check warning

Code scanning / Checkmarx One

Use Of Hardcoded Password Medium

Use Of Hardcoded Password
Username: "username",
Email: "email",
Password: "password",
NewPassword: "new-password",
CurrentPassword: "current-password",
ConfirmPassword: "confirm-password",

Check warning

Code scanning / Checkmarx One

Use Of Hardcoded Password Medium

Use Of Hardcoded Password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant