Skip to content

[PM-22513] Add .well-known/change-password redirect rule to server routing #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Jun 9, 2025

🎟️ Tracking

PM-22513

📔 Objective

Per https://www.w3.org/TR/change-password-url/ and in service of enabling testing risk-insights features, we should add a .well-known/change-password redirect rule to server routing

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jprusik jprusik self-assigned this Jun 9, 2025
@jprusik jprusik requested a review from a team as a code owner June 9, 2025 16:37
@@ -6,6 +6,8 @@ export const ROUTES = {
LOGIN: "/login",
PAYMENT: "/payment",
SEARCH: "/search",
WELL_KNOWN_CHANGE_PASSWORD: "/.well-known/change-password",
UPDATE_PASSWORD_FORM: "/forms/update/update-password",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this has potential to become stale if docusaurus generates a different path for this page or it otherwise goes away

Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Copy link

github-actions bot commented Jun 9, 2025

Logo
Checkmarx One – Scan Summary & Details999a526e-c014-44f3-8a03-274810b7cc81

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-30359 Npm-webpack-dev-server-4.15.2
detailsRecommended version: 5.2.1
Description: The webpack-dev-server allows users to use webpack with a development server that provides live reloading. The webpack-dev-server users' source cod...
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: Wv3oR8vzAw2Bq7dejwj3VOK7QfRu%2FRm%2FGJTrHDuj3P0%3D
Vulnerable Package

Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jprusik!

@jprusik jprusik merged commit fa6a7d2 into main Jun 9, 2025
7 checks passed
@jprusik jprusik deleted the pm-22513 branch June 9, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants