Skip to content

[PM-18520] Add feature flag for new desktop cipher forms #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

bnagawiecki
Copy link
Contributor

🎟️ Tracking

📔 Objective

Add feature flag for the new desktop cipher forms, so it returns from /config

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Apr 7, 2025

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found Info
[Desktop] Migrate Vault pages to component library (folders/cipher forms/collections/mp reprompt) pm-18520-desktop-cipher-forms

Copy link

sonarqubecloud bot commented Apr 7, 2025

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.34%. Comparing base (7c76edd) to head (5e1c756).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5621   +/-   ##
=======================================
  Coverage   45.34%   45.34%           
=======================================
  Files        1565     1565           
  Lines       71731    71731           
  Branches     6424     6424           
=======================================
  Hits        32530    32530           
  Misses      37811    37811           
  Partials     1390     1390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Logo
Checkmarx One – Scan Summary & Details84f84bf7-144e-4ac8-a9d8-6f5b5ac888ce

Great job, no security vulnerabilities found in this Pull Request

@bnagawiecki bnagawiecki merged commit 01daad5 into main Apr 7, 2025
54 checks passed
@bnagawiecki bnagawiecki deleted the pm-18520-desktop-cipher-form-feature-flag branch April 7, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants