[PM-19888] Automatic Tax flag not properly updated after deleting tax id

[jonashendrickx]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19888

📔 Objective

1. Create Non US business org with VAT value applied
2. change payment method
3. remove VAT on new payment method
4. Can use the same zip code or change it (doesn’t matter)
5. Automatic tax remains enabled - this should be disabled upon removal

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 44.61078% with 185 lines in your changes missing coverage. Please review.

Project coverage is 44.90%. Comparing base (0ca1b31) to head (310770f).
Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/Services/Implementations/StripePaymentService.cs	0.00%	58 Missing ⚠️
...ling/Services/Implementations/SubscriberService.cs	24.19%	42 Missing and 5 partials ⚠️
...ns/AutomaticTax/PersonalUseAutomaticTaxStrategy.cs	52.50%	19 Missing ⚠️
...ns/AutomaticTax/BusinessUseAutomaticTaxStrategy.cs	76.27%	14 Missing ⚠️
...Services/Implementations/UpcomingInvoiceHandler.cs	0.00%	13 Missing ⚠️
...ices/Implementations/OrganizationBillingService.cs	21.42%	11 Missing ⚠️
...vices/Implementations/PremiumUserBillingService.cs	23.07%	10 Missing ⚠️
...Providers/RemoveOrganizationFromProviderCommand.cs	75.00%	3 Missing and 1 partial ⚠️
.../Commercial.Core/Billing/ProviderBillingService.cs	66.66%	3 Missing and 1 partial ⚠️
...ervices/Contracts/AutomaticTaxFactoryParameters.cs	75.00%	4 Missing ⚠️
... and 1 more

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #5607    +/-   ##
========================================
  Coverage   44.90%   44.90%            
========================================
  Files        1559     1562     +3     
  Lines       71146    71381   +235     
  Branches     6355     6387    +32     
========================================
+ Hits        31945    32052   +107     
- Misses      37850    37969   +119     
- Partials     1351     1360     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Checkmarx One – Scan Summary & Details – bb77bcf6-93ba-4bb5-a3c4-7f9e9a3305ac

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Billing/Controllers/PayPalController.cs: 70	details Method PostIpn at line 70 of /src/Billing/Controllers/PayPalController.cs gets a parameter from a user request from Body. This parameter value flow... Attack Vector
	SSL_Verification_Bypass	/src/Core/Services/Implementations/MailKitSmtpMailDeliveryService.cs: 73	details /src/Core/Services/Implementations/MailKitSmtpMailDeliveryService.cs relies HTTPS requests, in SendEmailAsync. The ServerCertificateValidationCallb... Attack Vector
	Missing_CSP_Header	/src/Core/MailTemplates/Handlebars/SecurityTasksNotification.html.hbs: 20	details A Content Security Policy is not explicitly defined within the web-application. Attack Vector

Fixed Issues (10)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 81
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 164
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 164
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 86
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 96
	CSRF	/src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 185
	CSRF	/src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 76
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 77
	SSL_Verification_Bypass	/src/Core/Services/Implementations/MailKitSmtpMailDeliveryService.cs: 76