-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add SMTP Mail Tests #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SMTP Mail Tests #5597
Conversation
Co-authored-by: tangowithfoxtrot <[email protected]>
69b87fb
to
d6eb6bd
Compare
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (7)Great job! The following issues were fixed in this Pull Request
|
test/Core.IntegrationTest/MailKitSmtpMailDeliveryServiceTests.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5597 +/- ##
==========================================
+ Coverage 44.99% 45.05% +0.06%
==========================================
Files 1562 1563 +1
Lines 71493 71605 +112
Branches 6403 6407 +4
==========================================
+ Hits 32168 32262 +94
- Misses 37959 37973 +14
- Partials 1366 1370 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
📔 Objective
We are going to be adding functionality to allow the adding a certificates to the trust store without going through
update-ca-certificates
to support non-root scenarios. SMTP is one of the areas that needs consideration. While working on those changes @tangowithfoxtrot and I started on some tests and these are the result of that. The new functionality and at least one new test will be added in a later PR.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes