PM-17921 change the GenerateAccessData method to process lists in parallel #5552
+66
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prograhamming
changed the title
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5552 +/- ##
==========================================
- Coverage 45.66% 45.65% -0.01%
==========================================
Files 1597 1597
Lines 72490 72502 +12
Branches 6495 6493 -2
==========================================
Hits 33101 33101
- Misses 37974 37986 +12
Partials 1415 1415 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ttalty
requested changes
Mar 27, 2025
src/Core/Tools/ReportFeatures/MemberAccessCipherDetailsQuery.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
⛏️ We should also get rid of the GenerateAccessData method itself
There was a problem hiding this comment.
Removed old method
ttalty
approved these changes
Mar 28, 2025
|
prograhamming
deleted the
tools/pm-17921/performance-testing-member-access-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17921
📔 Objective
Testing the performance of the MemberAccessCipherDetailsQuery with an organization with a large amount of members. Found we could reduce the response time of this method by 300ms when processing lists in parallel.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes