Skip to content

[PM-18170] Remove PM-15814-alert-owners-of-reseller-managed-orgs #5412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 9, 2025

Conversation

jonashendrickx
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18170

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner February 18, 2025 13:19
Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Self-serve flow to re-subscribe PM-15814-alert-owners-of-reseller-managed-orgs ✅ all references removed

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.66%. Comparing base (01daad5) to head (4cfc6b9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
- Coverage   45.66%   45.66%   -0.01%     
==========================================
  Files        1597     1597              
  Lines       72490    72484       -6     
  Branches     6495     6494       -1     
==========================================
- Hits        33101    33098       -3     
+ Misses      37974    37972       -2     
+ Partials     1415     1414       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Logo
Checkmarx One – Scan Summary & Details2bcddcf3-c293-43f0-a479-26b68d23acfb

New Issues (5)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
detailsMethod Put at line 164 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter val...
Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 94
detailsMethod Put at line 94 of /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs gets a parameter from a user request from model. This param...
Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
detailsMethod Put at line 133 of /src/Api/AdminConsole/Public/Controllers/GroupsController.cs gets a parameter from a user request from model. This parame...
Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 104
detailsMethod Patch at line 104 of /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs gets a parameter from a user request from model. This pa...
Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/OrganizationUserRevokedForSingleOrgPolicy.html.hbs: 5
detailsA Content Security Policy is not explicitly defined within the web-application.
Attack Vector

# Conflicts:
#	src/Billing/Services/Implementations/SubscriptionUpdatedHandler.cs
@jonashendrickx
Copy link
Contributor Author

Fixed merge conflict

@rr-bw rr-bw requested review from ike-kottlowski and removed request for rr-bw March 18, 2025 17:02
Copy link
Contributor

@BTreston BTreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests, probably from removing Duende.IdentityModel in those test files.

@jonashendrickx jonashendrickx requested a review from BTreston March 27, 2025 12:58
BTreston
BTreston previously approved these changes Mar 27, 2025
ike-kottlowski
ike-kottlowski previously approved these changes Apr 7, 2025
Copy link

sonarqubecloud bot commented Apr 7, 2025

@jonashendrickx jonashendrickx merged commit f8e89f1 into main Apr 9, 2025
54 checks passed
@jonashendrickx jonashendrickx deleted the PM-18170-Remove-PM-15814-alert branch April 9, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants