-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-18170] Remove PM-15814-alert-owners-of-reseller-managed-orgs #5412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LaunchDarkly flag references❌ 1 flag removed
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5412 +/- ##
==========================================
- Coverage 45.66% 45.66% -0.01%
==========================================
Files 1597 1597
Lines 72490 72484 -6
Branches 6495 6494 -1
==========================================
- Hits 33101 33098 -3
+ Misses 37974 37972 -2
+ Partials 1415 1414 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New Issues (5)Checkmarx found the following issues in this Pull Request
|
# Conflicts: # src/Billing/Services/Implementations/SubscriptionUpdatedHandler.cs
Fixed merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests, probably from removing Duende.IdentityModel
in those test files.
# Conflicts: # src/Core/Constants.cs
4cfc6b9
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18170
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes