Fix service registration for PasswordlessClient
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyrrrz
commented
Oct 23, 2023
| @@ -5,7 +5,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Passwordless" Version="1.0.2" /> | |||
| <ProjectReference Include="..\..\src\Passwordless\Passwordless.csproj" /> | |||
There was a problem hiding this comment.
I switched this to a local reference while debugging/testing and was wondering if we should keep it this way? Apparently the Identity example already uses a local reference. It's quite convenient to test things out using a version that hasn't been released yet.
There was a problem hiding this comment.
Agreed on the testing convenience. Can't think of a reason to not do it. 👍
There was a problem hiding this comment.
@abergs wanted the examples to be copy-pastable and the end-user would use a PackageReference instead. However, I'm wondering if it's worth it, considering the effort of switching the reference back and forth when testing locally 🤔
jrmccannon
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56