Skip to content

PAS179: Migrate ASP.NET Identity example #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Passwordless.sln
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "examples", "examples", "{6E
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Passwordless.Example", "examples\Passwordless.Example\Passwordless.Example.csproj", "{15D70E7A-D222-4C60-93B2-06570A2BE5F2}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Passwordless.AspNetIdentity.Example", "examples\Passwordless.AspNetIdentity.Example\Passwordless.AspNetIdentity.Example.csproj", "{F9487727-715D-442F-BE2F-7FB9931606C2}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should call the project .AspNetCore. to match the naming convention we adopted in the SDK? Or should we try to move away from that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, I would maybe rename the project to put Example part first: Passwordless.Example.AspNetIdentity.

EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand All @@ -55,6 +57,10 @@ Global
{15D70E7A-D222-4C60-93B2-06570A2BE5F2}.Debug|Any CPU.Build.0 = Debug|Any CPU
{15D70E7A-D222-4C60-93B2-06570A2BE5F2}.Release|Any CPU.ActiveCfg = Release|Any CPU
{15D70E7A-D222-4C60-93B2-06570A2BE5F2}.Release|Any CPU.Build.0 = Release|Any CPU
{F9487727-715D-442F-BE2F-7FB9931606C2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{F9487727-715D-442F-BE2F-7FB9931606C2}.Debug|Any CPU.Build.0 = Debug|Any CPU
{F9487727-715D-442F-BE2F-7FB9931606C2}.Release|Any CPU.ActiveCfg = Release|Any CPU
{F9487727-715D-442F-BE2F-7FB9931606C2}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand All @@ -65,5 +71,6 @@ Global
{EBC084B5-42AD-474D-A63C-EBF7C423F993} = {8FC08940-3E9D-4AE5-AB1D-940B4D5DC0E6}
{F64C850E-9923-43F1-BC84-432AFBBA4425} = {8FC08940-3E9D-4AE5-AB1D-940B4D5DC0E6}
{15D70E7A-D222-4C60-93B2-06570A2BE5F2} = {6EFECBD2-2BF5-473D-A7C3-A1F3A3F1816A}
{F9487727-715D-442F-BE2F-7FB9931606C2} = {6EFECBD2-2BF5-473D-A7C3-A1F3A3F1816A}
EndGlobalSection
EndGlobal
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Integration packages:
Examples:

- [Passwordless.Example](examples/Passwordless.Example) — basic Passwordless.dev integration inside an ASP.NET Core app
- [Passwordless.AspNetIdentity.Example](examples/Passwordless.AspNetIdentity.Example) — Passwordless.dev integration using ASP.NET Identity.

## Getting started

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
using Microsoft.Extensions.DependencyInjection;

namespace Passwordless.DataContext;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the namespaces so they match the project name?


public static class DataContextBootstrap
{
public static void AddDataContext(this IServiceCollection services)
{
services.AddDbContext<PasswordlessContext>();
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading