-
Notifications
You must be signed in to change notification settings - Fork 15
Repatriate the ASP.NET Core SDK under the monorepo #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note that the current GitHub token provided by the CI does not have permissions to push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I even thought that maybe... maybe... we should add our examples into the same repo as the SDK. Unless there is a better way. Not sure yet!
Yes please, just have an |
@abergs you mean this repo, right? https://github.com/passwordless/passwordless-dotnet-example |
Added the example @abergs @justindbaur It references the SDK by PackageReference, not ProjectReference, like Anders suggested, so that users can still easily copy-paste the sources. Note the failing |
As far as I know, the ASP.NET Core SDK was split out from the previous monorepo, which included Passwordless.Server. While it makes sense for the Server repo to be separate from the SDK projects, keeping the SDKs together provides us with a lot of benefits:
.AspNetCore
in this case) will always be tested and released against the latest version of the core SDK.editorconfig
etc) instead of copy-pasting