Skip to content

Repatriate the ASP.NET Core SDK under the monorepo #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Sep 25, 2023

As far as I know, the ASP.NET Core SDK was split out from the previous monorepo, which included Passwordless.Server. While it makes sense for the Server repo to be separate from the SDK projects, keeping the SDKs together provides us with a lot of benefits:

  • We can use the same exact CI workflow without any additions or changes
  • Test and deploy flows will work exactly the same for both
  • Dependent SDKs (.AspNetCore in this case) will always be tested and released against the latest version of the core SDK
  • Better discoverability and issue management: users won't have to figure out where to report their bugs
  • We can share tooling (.editorconfig etc) instead of copy-pasting

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 25, 2023

Note that the current GitHub token provided by the CI does not have permissions to push Passwordless.AspNetCore to the registry. The same problem will likely occur with the NuGet token too, I'm not sure what scopes are set there.

@Tyrrrz Tyrrrz requested a review from abergs September 26, 2023 09:45
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I even thought that maybe... maybe... we should add our examples into the same repo as the SDK. Unless there is a better way. Not sure yet!

@justindbaur
Copy link
Member

add our examples into the same repo

Yes please, just have an examples directory.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 26, 2023

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 26, 2023

Added the example @abergs @justindbaur

It references the SDK by PackageReference, not ProjectReference, like Anders suggested, so that users can still easily copy-paste the sources.

Note the failing deploy job, something needs to be done about that

@Tyrrrz Tyrrrz merged commit 8e0dc27 into main Sep 27, 2023
@Tyrrrz Tyrrrz deleted the merge-aspnet-sdk branch September 27, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants