Skip to content

Add 'POST /alias' #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Add 'POST /alias' #18

merged 3 commits into from
Sep 8, 2023

Conversation

jonashendrickx
Copy link
Contributor

No description provided.

Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things I noticed.

@abergs
Copy link
Member

abergs commented Sep 8, 2023

@justindbaur @jonashendrickx Actually, posting an empty alias array is needed to clear aliases from the user. So we should definitely not require the list to be of length >= 1

@jonashendrickx jonashendrickx merged commit 2da5d23 into main Sep 8, 2023
@jonashendrickx jonashendrickx deleted the 20230907addaliasendpoint branch September 8, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants