Skip to content

Add JSON Source Gen #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Add JSON Source Gen #17

merged 3 commits into from
Sep 1, 2023

Conversation

justindbaur
Copy link
Member

  • Add more direct target frameworks
    • netstandard2.0, net6.0 and only behind a opt-in property net8.0.
    • With netstandard2.0 we get a computed framework of net461
    • With net6.0 we support the current LTS version
    • With net8.0 we get to be ready for using new goodies in preview
  • Remove all anonymous types.
  • Make all response types immutable.
    • This also removes nullable warnings that we were getting.
  • Use JSON Source Generators
  • Add more tests that fully cover PasswordlessClient and run against the API in a mock mode (not PR'ed yet).

- LTS Target
- AOT Analyzer for .NET 8
@justindbaur justindbaur requested a review from abergs August 30, 2023 12:48
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. One question for jonas.

Did you confirm it worked against the API?

@justindbaur
Copy link
Member Author

justindbaur commented Sep 1, 2023

@abergs Yes, I ran it against it in "mock mode" in this branch. Including the .NET Framework 4.6.2 target.

@abergs
Copy link
Member

abergs commented Sep 1, 2023

@justindbaur looks good to me

@justindbaur justindbaur merged commit 75fade0 into main Sep 1, 2023
@justindbaur justindbaur deleted the add-json-source-gen branch September 1, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants