Skip to content

.NET SDK: Options pattern is not reading updated values #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jonashendrickx
Copy link
Contributor

@jonashendrickx jonashendrickx commented Mar 19, 2024

We currently cannot read updated values when the appsettings.json or environment variables change. The ASP.NET Identity SDK has to be fixed separately.

@jonashendrickx jonashendrickx requested a review from a team March 19, 2024 06:47
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 60.19%. Comparing base (6a01e85) to head (12931c9).

Files Patch % Lines
src/Passwordless/ServiceCollectionExtensions.cs 50.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   60.00%   60.19%   +0.19%     
==========================================
  Files          42       42              
  Lines         615      613       -2     
  Branches       54       52       -2     
==========================================
  Hits          369      369              
+ Misses        240      238       -2     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx changed the title Options pattern binding .NET SDK: Options pattern is not reading updated values Mar 19, 2024
@jonashendrickx
Copy link
Contributor Author

#123

Comment on lines +52 to +54
/// <param name="services"></param>
/// <param name="section"></param>
/// <returns></returns>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <param name="services"></param>
/// <param name="section"></param>
/// <returns></returns>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants