Adding TTL to AuthenticationOptions #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nverting from TimeSpan to API friendly int.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 60.19% 60.00% -0.20%
==========================================
Files 41 42 +1
Lines 613 615 +2
Branches 53 54 +1
==========================================
Hits 369 369
- Misses 239 240 +1
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. |
jonashendrickx
suggested changes
Feb 29, 2024
jrmccannon
changed the title
Tyrrrz
reviewed
Feb 29, 2024
jonashendrickx
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAS-370
This adds TTL to the GenerateAuthenticationTokenAsync AuthenticationOptions record. It also adds an internal record that is used for the PasswordlessSerializerContext. This is because the API endpoint takes the TTL as an int of seconds.
TimeSpanis a nicer way to define a segment of time, so I added the layer for ease of use.Existing tests passed.