Skip to content

Cannot deserialize init properties #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

jrmccannon
Copy link
Contributor

init properties cannot be deserialized with the JsonSerializer source generation. This moves the properties from those init fields to optional parameters.

@jrmccannon jrmccannon requested a review from a team February 26, 2024 15:56
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 60.19%. Comparing base (72d00b5) to head (f552ff4).

Files Patch % Lines
src/Passwordless/Models/Credential.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   60.19%   60.19%           
=======================================
  Files          41       41           
  Lines         613      613           
  Branches       53       53           
=======================================
  Hits          369      369           
  Misses        239      239           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrmccannon jrmccannon merged commit 769a423 into main Feb 28, 2024
@jrmccannon jrmccannon deleted the change-init-to-optional branch February 28, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants