Skip to content

Allow Magic.cshtml to Use Magic LInks #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

jrmccannon
Copy link
Contributor

Currently, Magic.cshtml only works with the DIY magic links built on the MGAT feature. This will change the sample DIY magic link to work like the new magic link feature.

Testing done:

  • i've validated the existing flow continues to work.
  • the format matches the new magic link format.

@jrmccannon jrmccannon requested a review from a team February 23, 2024 17:06
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.19%. Comparing base (854d3e5) to head (8cfbb09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   60.19%   60.19%           
=======================================
  Files          41       41           
  Lines         613      613           
  Branches       53       53           
=======================================
  Hits          369      369           
  Misses        239      239           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample doesn't use the Magic Link API to send links yet, right?

@jrmccannon jrmccannon merged commit 72d00b5 into main Feb 26, 2024
@jrmccannon jrmccannon deleted the allow-for-magic-links-to-work branch February 26, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants