Skip to content

Add support for assembly trimming and AOT #132

Open
@Tyrrrz

Description

@Tyrrrz

#130 added annotations for APIs that dynamically reference code (usually through reflection). These methods are, in essence, in compatible with trimming/AOT.

This means that the only available way to set up the raw Passwordless.dev SDK is by using this overload, which requires configuring the options manually:

public static IServiceCollection AddPasswordlessSdk(
        this IServiceCollection services,
        Action<PasswordlessOptions> configureOptions)

For the Identity integration package, we currently offer no way to add Passwordless.dev in a way that works with trimming/AOT.

Some of it may be a side-effect of the nature of ASP.NET Core as the foundation, but Microsoft is already rolling out certain alternative APIs to help support trimming/AOT scenarios. For example, for the configuration binding, we can use this approach to avoid reflection.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions