Skip to content

Update README to avoid duplicative documentation of setup #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented May 30, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22246

📔 Objective

Removed the configuration instructions from the README so that they don't diverge from those in the Help Center, and instead reference the Help Center directly. We had a customer who attempted to use the instructions in the README, and their resulting configuration identified that the instructions had diverged.

Integrations would prefer that the Help Center be the source of truth in deployment instructions, given that the instructions are targeted at enterprises whose point of contact for Bitwarden documentation is the Help Center.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.04%. Comparing base (9585dc6) to head (eac84e5).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #214   +/-   ##
=====================================
  Coverage   7.04%   7.04%           
=====================================
  Files         49      49           
  Lines       1818    1818           
  Branches      99      99           
=====================================
  Hits         128     128           
  Misses      1685    1685           
  Partials       5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa7e04c8a-d4c4-4298-93f5-1a236aba8bf9

Great job, no security vulnerabilities found in this Pull Request

@trmartin4 trmartin4 marked this pull request as ready for review May 31, 2025 01:50
@trmartin4 trmartin4 requested a review from a team as a code owner May 31, 2025 01:50
@@ -4,215 +4,11 @@ The Bitwarden Key Connector is a self-hosted web application that stores and pro
clients.

The Key Connector project is written in C# using .NET Core with ASP.NET Core. The codebase can be developed, built, run,
and deployed cross-platform on Windows, macOS, and Linux distributions.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is this correct? We include "developed, built, run, and deployed" in one sentence here. As far as I understand, the former 3 are (still) supported on mac. Only deployment is Windows and Linux only. Can we split this into two sentences, than accurately describe the supported scenarios?

"The codebase can be developed, built and run on Windows, macOS and Linux. Production deployment is supported for Windows and Linux."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants