[BITAU-152] Handle Vault Lock/Unlock with Sync #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-coredata-store
…ges out of DataStore to prepare for refactor in the brant/create-coredata-store branch
… Keep DataStore generic
…M app CoreData semantics. Refactor conveience methods to new service class
brant-livefront
requested review from
matt-livefront,
phil-livefront,
victor-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
=======================================
Coverage 89.07% 89.07%
=======================================
Files 660 660
Lines 41292 41292
=======================================
+ Hits 36780 36781 +1
+ Misses 4512 4511 -1 ☔ View full report in Codecov by Sentry. |
fedemkr
reviewed
Oct 3, 2024
BitwardenShared/Core/Platform/Services/AuthenticatorSyncService.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Platform/Services/AuthenticatorSyncService.swift
Outdated
Show resolved
Hide resolved
fedemkr
previously approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Looks good on my side! However I'd wait for @matt-livefront and @KatherineInCode to review as well in case I've missed something.
BitwardenShared/Core/Platform/Services/AuthenticatorSyncService.swift
Outdated
Show resolved
Hide resolved
matt-livefront
previously approved these changes
Oct 7, 2024
BitwardenShared/Core/Platform/Services/AuthenticatorSyncServiceTests.swift
Show resolved
Hide resolved
BitwardenShared/Core/Platform/Services/AuthenticatorSyncService.swift
Outdated
Show resolved
Hide resolved
matt-livefront
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BITAU-152
📔 Objective
As I mentioned in the previous PR, I needed to add explicit handling of vault lock/unlock status when performing sync. This PR adds subscribers for both the vault status as well as the sync setting. When either is updated (for any account), we examine if that account is ready for sync or not. To be ready for sync, the user must have opted in to sync and they must have an unlocked vault. If either of those are missing, we dismantle any cipher listening and wait for another signal. I've also added a lot of tests to cover all the various scenarios with multiple accounts.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes