Skip to content

[PM-12580] Adds CI for the internal Beta build #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 58 commits into from
Oct 3, 2024
Merged

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 24, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12580

📔 Objective

Automates building and distributing an internal Beta build with the Debug Menu available. This may be used in the near future for preview xcode features.

Also bumps the base version number to fix builds failing in main.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner September 24, 2024 21:04
@vvolkgang vvolkgang changed the base branch from main to ci-version-name September 24, 2024 21:05
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (db484ff) to head (629d605).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files         657      657           
  Lines       41317    41317           
=======================================
  Hits        36814    36814           
  Misses       4503     4503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Logo
Checkmarx One – Scan Summary & Details5c493ba5-ae77-46cf-9ed0-46d195efc76d

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /CI-main.yml: 86 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although there seems to be a Linter issue on the checks.

fedemkr
fedemkr previously approved these changes Sep 30, 2024
@vvolkgang vvolkgang force-pushed the ci-version-name branch 12 times, most recently from d639159 to 7112430 Compare October 3, 2024 21:01
# Conflicts:
#	.github/workflows/CI-main.yml
Base automatically changed from ci-version-name to main October 3, 2024 21:31
@vvolkgang vvolkgang dismissed fedemkr’s stale review October 3, 2024 21:31

The base branch was changed.

@vvolkgang vvolkgang removed the hold This shouldn't be merged yet label Oct 3, 2024
@vvolkgang vvolkgang enabled auto-merge (squash) October 3, 2024 21:52
@vvolkgang vvolkgang merged commit 5e5208c into main Oct 3, 2024
9 checks passed
@vvolkgang vvolkgang deleted the automate-internal branch October 3, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants