Skip to content

PM-9001 - Item with MP Reprompt does not prompt for MP when downloading attachment #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

phil-livefront
Copy link
Collaborator

@phil-livefront phil-livefront commented Jul 26, 2024

🎟️ Tracking

PM-9001

📔 Objective

  • Prompt user for a master password when downloading an attachment. Right now we freely allow downloading an attachment without asking for the password.

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-26.at.15.38.14.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1a2170e3-cb60-4ca1-94ca-00bafad3443f

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (4712b00) to head (01e2d9f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files         577      577           
  Lines       29104    29104           
=======================================
  Hits        25648    25648           
  Misses       3456     3456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-livefront phil-livefront merged commit 5d78b16 into main Jul 26, 2024
8 checks passed
@phil-livefront phil-livefront deleted the phil/PM-9001-download-master-password-reprompt branch July 26, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants