PM-9660: Improve autofill extension flow with never lock #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-livefront
requested review from
fedemkr,
phil-livefront and
KatherineInCode
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 88.09% 88.09% -0.01%
==========================================
Files 577 577
Lines 28890 28889 -1
==========================================
- Hits 25451 25450 -1
Misses 3439 3439 ☔ View full report in Codecov by Sentry. |
fedemkr
reviewed
Jul 23, 2024
BitwardenShared/Core/Autofill/Services/AutofillCredentialService.swift
Outdated
Show resolved
Hide resolved
fedemkr
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-9660
📔 Objective
If an account has never lock enabled, this unlocks the vault without user interaction prior to autofilling. This fixes a UI issue where a navigation controller would pop up briefly before the vault was unlocked.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-23.at.10.19.09.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-23.at.10.15.53.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes