-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-22419] dismiss account nudge when biometric unlock is set #15139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #15139 +/- ##
=======================================
Coverage 36.86% 36.86%
=======================================
Files 3216 3216
Lines 92773 92785 +12
Branches 13934 13935 +1
=======================================
+ Hits 34197 34204 +7
- Misses 57171 57176 +5
Partials 1405 1405 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
PM-22419
PM-22422
📔 Objective
Update account-security-nudge service to look at biomentricUnlockEnabled$ observable
Add Success Toast for Biometric Unlock
Added logic to set nudge status if Pin or biometric is turned on to permanently dismiss, so if user turns it off the nudge still will not appear.
PM-22422 Also dismiss nudge if user has at least 1 org with
Remove Unlock With PIN
policy on📸 Screen Recording
PM-22419-biometric-unlock-nudge-dismiss.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes