Skip to content

Migrate remaining components to standalone in libs/components #15053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 3, 2025

🎟️ Tracking

📔 Objective

Migrates the remaining non standalone components from libs/components. Also resolved some linting ignores and applying strict typescript.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner June 3, 2025 09:33
@Hinton Hinton requested a review from vleague2 June 3, 2025 09:33
Copy link

sonarqubecloud bot commented Jun 3, 2025

Copy link
Contributor

github-actions bot commented Jun 3, 2025

Logo
Checkmarx One – Scan Summary & Details6da0981e-a889-4442-87e7-4bc17ac2e135

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.82%. Comparing base (95856bf) to head (886f899).
Report is 23 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...bs/components/src/dialog/dialog.service.stories.ts 0.00% 3 Missing ⚠️
...alog/simple-configurable-dialog.service.stories.ts 0.00% 2 Missing ⚠️
...log/simple-dialog/simple-dialog.service.stories.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15053   +/-   ##
=======================================
  Coverage   36.82%   36.82%           
=======================================
  Files        3199     3199           
  Lines       92749    92744    -5     
  Branches    13924    13924           
=======================================
  Hits        34155    34155           
+ Misses      57188    57183    -5     
  Partials     1406     1406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton merged commit e8e2181 into main Jun 5, 2025
98 checks passed
@Hinton Hinton deleted the uif/components-no-standalone branch June 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants