Skip to content

[CL-714] Remove standalone true from dirt #15041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 2, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-714

📔 Objective

Remove standalone: true from every instance since it's the default as of Angular 19.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner June 2, 2025 18:40
Copy link

sonarqubecloud bot commented Jun 2, 2025

Copy link
Contributor

github-actions bot commented Jun 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsde5cd26c-4b9d-4502-b8cc-73df033e6771

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.80%. Comparing base (26fb7ef) to head (0e28a5c).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15041      +/-   ##
==========================================
- Coverage   36.81%   36.80%   -0.01%     
==========================================
  Files        3201     3201              
  Lines       92826    92826              
  Branches    13934    13934              
==========================================
- Hits        34174    34167       -7     
- Misses      57246    57253       +7     
  Partials     1406     1406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton enabled auto-merge (squash) June 2, 2025 19:48
@Hinton Hinton merged commit 5fd7c18 into main Jun 3, 2025
98 checks passed
@Hinton Hinton deleted the arch/standalone-dirt branch June 3, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants