Hide credentials that are in the bin #15034
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## feature/passkey-provider #15034 +/- ##
===========================================================
Coverage ? 36.24%
===========================================================
Files ? 3200
Lines ? 92864
Branches ? 16695
===========================================================
Hits ? 33660
Misses ? 56781
Partials ? 2423 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
jprusik
approved these changes
Jun 2, 2025
jprusik
reviewed
Jun 2, 2025
| @@ -94,7 +94,8 @@ export class Fido2CreateComponent implements OnInit, OnDestroy { | |||
|
|
|||
| return ( | |||
| cipher.login.matchesUri(rpid, equivalentDomains) && | |||
| Fido2Utils.cipherHasNoOtherPasskeys(cipher, userHandle) | |||
| Fido2Utils.cipherHasNoOtherPasskeys(cipher, userHandle) && | |||
| !cipher.deletedDate | |||
There was a problem hiding this comment.
Does deletedDate get nulled out if the item is restored from the delete bin?
There was a problem hiding this comment.
Yes, it is set to null when restored.
coltonhurst
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PM-20347
📔 Objective
Hide credentials that are in the bin. This change addresses the create credential and vault modals.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes