Skip to content

[PM-20428] Replace Autofill-owned enums #15031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

[PM-20428] Replace Autofill-owned enums #15031

merged 1 commit into from
Jun 3, 2025

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Jun 2, 2025

๐ŸŽŸ๏ธ Tracking

PM-20428

๐Ÿ“” Objective

Follow up from #14347 and subsequent internal discussion, this PR handles only Autofill-owned enums

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@jprusik jprusik self-assigned this Jun 2, 2025
@jprusik jprusik marked this pull request as ready for review June 2, 2025 15:11
@jprusik jprusik requested a review from a team as a code owner June 2, 2025 15:11
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ debfcef0-7f4e-4701-97a7-432bc1d3b8b3

Great job, no security vulnerabilities found in this Pull Request

@jprusik jprusik marked this pull request as draft June 2, 2025 15:27
@jprusik jprusik force-pushed the pm-20428-autofill branch from 37166f1 to cdecb05 Compare June 2, 2025 15:39
@jprusik jprusik force-pushed the pm-20428-autofill branch from cdecb05 to 272e8b3 Compare June 2, 2025 15:54
Copy link

sonarqubecloud bot commented Jun 2, 2025

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.29%. Comparing base (79fa246) to head (272e8b3).
Report is 25 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...er/src/autofill/fido2/content/fido2-page-script.ts 40.00% 3 Missing โš ๏ธ
...src/autofill/fido2/content/fido2-content-script.ts 66.66% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15031      +/-   ##
==========================================
- Coverage   36.29%   36.29%   -0.01%     
==========================================
  Files        3202     3201       -1     
  Lines       93347    93321      -26     
  Branches    16835    16832       -3     
==========================================
- Hits        33878    33868      -10     
+ Misses      57027    57009      -18     
- Partials     2442     2444       +2     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jprusik jprusik marked this pull request as ready for review June 2, 2025 19:47
@jprusik jprusik merged commit 6dabdd7 into main Jun 3, 2025
45 checks passed
@jprusik jprusik deleted the pm-20428-autofill branch June 3, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants