Skip to content

Refactor PendingSecurityTasks to RefreshSecurityTasks #15021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nick-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

Server PR: bitwarden/server#5903

As a part of bitwarden/server#5896, I utilized the PendingSecurityTasks push type to trigger a refresh of the security tasks. This is currently on the notification is utilized but now the name PendingSecurityTasks won't match the all of the use cases.

This renames PendingSecurityTasks to RefreshSecurityTasks to align for more general use cases of security task notifications.

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

- Allows for more general use case of security task notifications
Copy link

sonarqubecloud bot commented Jun 2, 2025

Copy link
Contributor

github-actions bot commented Jun 2, 2025

Logo
Checkmarx One – Scan Summary & Details1a786a0d-ebbb-4a37-8314-69d46cd586c5

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.30%. Comparing base (f55f315) to head (5953e9f).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15021   +/-   ##
=======================================
  Coverage   36.30%   36.30%           
=======================================
  Files        3202     3202           
  Lines       93347    93347           
  Branches    16835    16835           
=======================================
  Hits        33885    33885           
  Misses      57020    57020           
  Partials     2442     2442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant