Skip to content

[PM-15001] Replace throttle decorator #15015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Banrion
Copy link
Contributor

@Banrion Banrion commented May 30, 2025

🎟️ Tracking

PM-15001

📔 Objective

This pull request removes the throttle decorator used in Audit Service by utilizing rxjs and sets a max concurrent limit.

  • Removed throttle decorator
  • Use rxjs mergeMap with concurrent limit for async requests
  • Adds a test case for the concurrent limit

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Banrion Banrion requested a review from a team as a code owner May 30, 2025 16:58
@Banrion Banrion requested a review from justindbaur May 30, 2025 16:58
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsddd48aa4-acd5-4ca3-898f-ef803890264f

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.28%. Comparing base (0715597) to head (4298716).
Report is 68 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/common/src/services/audit.service.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15015      +/-   ##
==========================================
+ Coverage   36.26%   36.28%   +0.01%     
==========================================
  Files        3202     3201       -1     
  Lines       93275    93316      +41     
  Branches    16823    16831       +8     
==========================================
+ Hits        33826    33856      +30     
- Misses      57007    57017      +10     
- Partials     2442     2443       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Banrion Banrion added the needs-qa Marks a PR as requiring QA approval label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants