Skip to content

[PM-21843] Deleted Ciphers Hide Import Nudge #15014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented May 30, 2025

🎟️ Tracking

PM-21843

📔 Objective

Account for deleted ciphers when choosing to display the import nudge.

📸 Screenshots

Before After
before-import.mov
after-import.mov

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@nick-livefront nick-livefront requested a review from a team as a code owner May 30, 2025 16:11
Copy link
Contributor

github-actions bot commented May 30, 2025

Logo
Checkmarx One – Scan Summary & Detailsd36c0505-7b27-4232-bcd0-b9764ab21179

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (4223a7e) to head (ac83653).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ustom-nudges-services/empty-vault-nudge.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15014      +/-   ##
==========================================
- Coverage   36.85%   36.84%   -0.01%     
==========================================
  Files        3199     3199              
  Lines       92728    92726       -2     
  Branches    13925    13925              
==========================================
- Hits        34172    34165       -7     
- Misses      57150    57155       +5     
  Partials     1406     1406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Jun 3, 2025

@nick-livefront nick-livefront merged commit 1bd77fe into main Jun 4, 2025
98 checks passed
@nick-livefront nick-livefront deleted the vault/pm-21843/empty-vault-trash branch June 4, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants