Skip to content

[PM-21791] Nudge UI Bug Fixes #15010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 4, 2025
Merged

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented May 30, 2025

🎟️ Tracking

PM-21791

📔 Objective

This addresses a couple of nudge UI issues:

  • Removes margin from the <ul> for the welcome spotlight
  • Adds missing badge for Import Items on the vault settings screen. This one required a new nudge service.
  • Updates title of vault settings screen to "Vault Options"
  • Adds spacing between the icon and title in the NoItemsComponent
    • @bitwarden/team-ui-foundation This was called out specifically for the empty vault screen. Looking through the designs for a couple of instances it looks to be applicable to all no items screens thus I applied it directly in the component.

📸 Screenshots

Welcome List Vault title, missing badge, icon spacing
Screenshot 2025-05-29 at 8 38 24 PM
Screen.Recording.2025-05-29.at.8.36.10.PM.mov

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@nick-livefront nick-livefront requested review from a team as code owners May 30, 2025 15:11
Copy link
Contributor

github-actions bot commented May 30, 2025

Logo
Checkmarx One – Scan Summary & Details2f8e6312-375b-4f9c-a19f-a746653ae754

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 30 lines in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (4223a7e) to head (c350db2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...es-services/vault-settings-import-nudge.service.ts 29.16% 17 Missing ⚠️
...ault/popup/settings/vault-settings-v2.component.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15010      +/-   ##
==========================================
- Coverage   36.85%   36.84%   -0.01%     
==========================================
  Files        3199     3200       +1     
  Lines       92728    92764      +36     
  Branches    13925    13930       +5     
==========================================
+ Hits        34172    34181       +9     
- Misses      57150    57177      +27     
  Partials     1406     1406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

willmartian
willmartian previously approved these changes May 30, 2025
Copy link

sonarqubecloud bot commented Jun 3, 2025

@nick-livefront nick-livefront merged commit 65f4ff6 into main Jun 4, 2025
98 checks passed
@nick-livefront nick-livefront deleted the vault/pm-21791/nudge-ui-changes branch June 4, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants