Skip to content

Confirm we can run the npm published CLI #15007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2025
Merged

Confirm we can run the npm published CLI #15007

merged 3 commits into from
Jun 9, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 30, 2025

🎟️ Tracking

📔 Objective

Confirm the dependencies in apps/cli/package.json are sufficient to run the CLI. (the version we publish to npm)

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from mandreko-bitwarden May 30, 2025 13:23
Copy link
Contributor

github-actions bot commented May 30, 2025

Logo
Checkmarx One – Scan Summary & Details15ae6824-831e-4045-a94a-81cdd352034e

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.25%. Comparing base (85cef97) to head (ca90768).
Report is 74 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15007      +/-   ##
==========================================
- Coverage   36.26%   36.25%   -0.01%     
==========================================
  Files        3202     3202              
  Lines       93310    93310              
  Branches    16835    16835              
==========================================
- Hits        33839    33832       -7     
- Misses      57029    57036       +7     
  Partials     2442     2442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton marked this pull request as ready for review May 30, 2025 14:09
@Hinton Hinton requested a review from a team as a code owner May 30, 2025 14:09
@Hinton Hinton requested a review from coroiu May 30, 2025 14:09
Copy link

@Hinton Hinton merged commit 685f7a0 into main Jun 9, 2025
42 checks passed
@Hinton Hinton deleted the arch/test-npm-cli branch June 9, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants