Skip to content

fix: broken SDK interface #14959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented May 27, 2025

🎟️ Tracking

📔 Objective

Add-userid-to-encryption-methods introduced breaking changes which blocks updates to the SDK. #14844 fixes these but will take too long to get merged and approved. This PR is just to add the minimal amount of required fixes

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coroiu coroiu requested a review from a team as a code owner May 27, 2025 10:34
@coroiu coroiu requested a review from tangowithfoxtrot May 27, 2025 10:34
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details107adc64-b241-4f59-9dbc-3410672f3102

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.34%. Comparing base (a6e2012) to head (769fe1b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14959   +/-   ##
=======================================
  Coverage   36.34%   36.34%           
=======================================
  Files        3208     3208           
  Lines       93271    93271           
  Branches    16836    16836           
=======================================
  Hits        33900    33900           
  Misses      56942    56942           
  Partials     2429     2429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coroiu coroiu requested a review from dani-garcia May 27, 2025 12:25
@coroiu coroiu merged commit 45f2104 into main May 27, 2025
99 checks passed
@coroiu coroiu deleted the coroiu/fix-broken-sdk-missing-user-id branch May 27, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants