Skip to content

[PM-21603]Invite Member sub text seat count does not account for sponsorships #14954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21603

📔 Objective

When an org has Family Sponsorships in a Sent or Active state, they consume an org seat

However, the Invite Member modal does not reflect these sponsorships in the available seat count

Replication steps

Enable the Admin Sponsored Families feature in the BW Admin Portal for desired Enterprise Org

In the Admin Console, go to Members > Free Bitwarden Families

Add sponsorship

Once sponsorship has been added, go to the Members > Members page

Invite member

Expected Result - The email field subtext should reflect the consumed seat in the ‘Enter up to x emails by separating with a comma.’

Actual Result - The email field subtext is not accounting for the sponsorship, so it displays an additional seat that is not actually available

📸 Screenshots

Screenshot 2025-05-26 at 23 19 07 Screenshot 2025-05-26 at 23 19 16 Screenshot 2025-05-26 at 23 19 28

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner May 26, 2025 22:20
@cyprain-okeke cyprain-okeke requested a review from r-tome May 26, 2025 22:20
Copy link
Contributor

github-actions bot commented May 26, 2025

Logo
Checkmarx One – Scan Summary & Detailsf1c3c2fa-c1cf-4409-a2db-33a4d78c8338

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.26%. Comparing base (4bf1a3b) to head (7b1219f).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...console/organizations/members/members.component.ts 0.00% 3 Missing ⚠️
...response/organization-billing-metadata.response.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14954      +/-   ##
==========================================
- Coverage   36.26%   36.26%   -0.01%     
==========================================
  Files        3202     3202              
  Lines       93265    93268       +3     
  Branches    16821    16821              
==========================================
  Hits        33825    33825              
- Misses      56998    57001       +3     
  Partials     2442     2442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to do this without adding another api call? This page is already slow as is

@cyprain-okeke
Copy link
Contributor Author

Is it possible to do this without adding another api call? This page is already slow as is

I am not sure, We have to get the number of admin family sponsored seat to get the outstanding seats

@cyprain-okeke cyprain-okeke requested a review from r-tome May 27, 2025 12:36
@r-tome
Copy link
Contributor

r-tome commented May 27, 2025

Is it possible to do this without adding another api call? This page is already slow as is

I am not sure, We have to get the number of admin family sponsored seat to get the outstanding seats

Can't that be added to OrganizationBillingMetadataResponse?

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner May 28, 2025 14:35
Copy link

@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud May 29, 2025 13:38 Inactive
@cyprain-okeke cyprain-okeke merged commit 0715597 into main May 29, 2025
98 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-21603-invite-member-sub-text-seat-count-does-not-account-for-sponsorships branch May 29, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants