-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-21603]Invite Member sub text seat count does not account for sponsorships #14954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-21603]Invite Member sub text seat count does not account for sponsorships #14954
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #14954 +/- ##
==========================================
- Coverage 36.26% 36.26% -0.01%
==========================================
Files 3202 3202
Lines 93265 93268 +3
Branches 16821 16821
==========================================
Hits 33825 33825
- Misses 56998 57001 +3
Partials 2442 2442 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to do this without adding another api call? This page is already slow as is
I am not sure, We have to get the number of admin family sponsored seat to get the outstanding seats |
Can't that be added to |
…oes-not-account-for-sponsorships
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21603
📔 Objective
When an org has Family Sponsorships in a Sent or Active state, they consume an org seat
However, the Invite Member modal does not reflect these sponsorships in the available seat count
Replication steps
Enable the Admin Sponsored Families feature in the BW Admin Portal for desired Enterprise Org
In the Admin Console, go to Members > Free Bitwarden Families
Add sponsorship
Once sponsorship has been added, go to the Members > Members page
Invite member
Expected Result - The email field subtext should reflect the consumed seat in the ‘Enter up to x emails by separating with a comma.’
Actual Result - The email field subtext is not accounting for the sponsorship, so it displays an additional seat that is not actually available
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes