Skip to content

[PM-21896] - prevent double reprompt for copy password in desktop cipher form #14883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21896

📔 Objective

This PR prevents double password prompt when copying a password in the desktop cipher form for a MP protected cipher.

📸 Screenshots

Screen.Recording.2025-05-22.at.9.29.57.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner May 22, 2025 16:30
Copy link
Contributor

github-actions bot commented May 22, 2025

Logo
Checkmarx One – Scan Summary & Detailsa940a75f-0788-44bb-b550-20219831b7de

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.48%. Comparing base (9417d8a) to head (a20073d).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/vault/app/vault/view.component.ts 0.00% 3 Missing ⚠️
...ibs/angular/src/vault/components/view.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14883      +/-   ##
==========================================
+ Coverage   36.42%   36.48%   +0.06%     
==========================================
  Files        3212     3207       -5     
  Lines       93266    93246      -20     
  Branches    16837    16838       +1     
==========================================
+ Hits        33972    34025      +53     
+ Misses      56826    56745      -81     
- Partials     2468     2476       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nick-livefront
nick-livefront previously approved these changes May 22, 2025
Copy link

@jaasen-livefront jaasen-livefront merged commit 57911f2 into main May 22, 2025
98 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-21896 branch May 22, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants