Skip to content

[PM-21086] Bugfix - Account Switcher Icon Size #14858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

rr-bw
Copy link
Contributor

@rr-bw rr-bw commented May 20, 2025

🎟️ Tracking

PM-21086

📔 Objective

Decreases the size of Account Switcher page icons from tw-text-2xl to tw-text-lg

❌ Old tw-text-2xl ✅ New tw-text-lg
tw-text-2xl tw-text-lg

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@rr-bw rr-bw marked this pull request as ready for review May 20, 2025 19:39
@rr-bw rr-bw requested a review from a team as a code owner May 20, 2025 19:39
Copy link
Contributor

github-actions bot commented May 20, 2025

Logo
Checkmarx One – Scan Summary & Details2c21d4f3-0bd4-46b9-a1fd-be8d76f7792b

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.41%. Comparing base (27884d9) to head (edb76d8).
Report is 20 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14858   +/-   ##
=======================================
  Coverage   36.41%   36.41%           
=======================================
  Files        3212     3212           
  Lines       93280    93280           
  Branches    16840    16840           
=======================================
  Hits        33966    33966           
  Misses      56846    56846           
  Partials     2468     2468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rr-bw rr-bw merged commit 23f4af6 into main May 23, 2025
45 checks passed
@rr-bw rr-bw deleted the auth/pm-21086/account-switcher-icon-update branch May 23, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants