Skip to content

refactor(browser-platform-utils): Remove Deprecation and Fix Code #14709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Patrick-Pimentel-Bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21438

📔 Objective

Removed references to deprecated functions.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…hanged usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.
Copy link
Contributor

github-actions bot commented May 9, 2025

Logo
Checkmarx One – Scan Summary & Details3a146bc5-326b-4a01-ba09-962f1d0b2dcc

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.48%. Comparing base (23f4af6) to head (1b407ed).
Report is 19 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pps/browser/src/platform/listeners/update-badge.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14709      +/-   ##
==========================================
- Coverage   36.49%   36.48%   -0.01%     
==========================================
  Files        3207     3207              
  Lines       93242    93241       -1     
  Branches    16833    16833              
==========================================
- Hits        34027    34020       -7     
- Misses      56742    56748       +6     
  Partials     2473     2473              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden marked this pull request as draft May 23, 2025 13:36
Copy link

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden marked this pull request as ready for review May 23, 2025 19:37
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden merged commit cb770f5 into main May 27, 2025
45 checks passed
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden deleted the auth/pm-21438/update-browser-identification-code branch May 27, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants