-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor(browser-platform-utils): Remove Deprecation and Fix Code #14709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(browser-platform-utils): Remove Deprecation and Fix Code #14709
Conversation
…hanged usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #14709 +/- ##
==========================================
- Coverage 36.49% 36.48% -0.01%
==========================================
Files 3207 3207
Lines 93242 93241 -1
Branches 16833 16833
==========================================
- Hits 34027 34020 -7
- Misses 56742 56748 +6
Partials 2473 2473 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21438
📔 Objective
Removed references to deprecated functions.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes