Skip to content

[CL-194] add vertical stepper to CL #14528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jun 6, 2025

Conversation

BryanCunningham
Copy link
Contributor

@BryanCunningham BryanCunningham commented Apr 28, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-194

📔 Objective

  • Move existing stepper component into component library
  • Update existing stepper to match component library best practices

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 29.68750% with 45 lines in your changes missing coverage. Please review.

Project coverage is 36.75%. Comparing base (299976e) to head (69f59b9).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/components/src/stepper/stepper.component.ts 25.92% 20 Missing ⚠️
...s/src/resize-observer/resize-observer.directive.ts 18.18% 9 Missing ⚠️
libs/components/src/stepper/stepper.stories.ts 0.00% 8 Missing ⚠️
libs/components/src/stepper/step.stories.ts 0.00% 6 Missing ⚠️
libs/components/src/stepper/step.component.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14528      +/-   ##
==========================================
- Coverage   36.77%   36.75%   -0.03%     
==========================================
  Files        3201     3208       +7     
  Lines       92661    92701      +40     
  Branches    13931    13934       +3     
==========================================
- Hits        34076    34068       -8     
- Misses      57179    57227      +48     
  Partials     1406     1406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 28, 2025

Logo
Checkmarx One – Scan Summary & Details782cc533-0a70-4bf9-9ada-238a58e866f9

Great job, no security vulnerabilities found in this Pull Request

@willmartian willmartian self-requested a review April 29, 2025 19:33
Copy link
Contributor

@vleague2 vleague2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts! Also, looks like Storybook has an error for the vertical stepper story

@BryanCunningham BryanCunningham force-pushed the uif/cl-194/add-vertical-stepper-to-CL branch from e4d0e56 to 9bcea9d Compare April 30, 2025 20:34
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the idea of renaming this bit-stepper, bit-step, etc with a default input of orientation="vertical".

Seems appropriate if we adding a horizontal variant and we expect it to have the same API shape (right?).

@willmartian willmartian changed the title Copy Vertical stepper into CL [CL-194] add vertical stepper to CL May 6, 2025
@BryanCunningham BryanCunningham force-pushed the uif/cl-194/add-vertical-stepper-to-CL branch 4 times, most recently from 4b7a6b2 to f338037 Compare May 12, 2025 16:31
@BryanCunningham BryanCunningham force-pushed the uif/cl-194/add-vertical-stepper-to-CL branch 7 times, most recently from 362caf2 to 3fdda09 Compare May 14, 2025 13:23
Copy link
Contributor

@vleague2 vleague2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions lol

@BryanCunningham BryanCunningham force-pushed the uif/cl-194/add-vertical-stepper-to-CL branch 2 times, most recently from e173335 to e10303d Compare May 26, 2025 15:08
@BryanCunningham BryanCunningham force-pushed the uif/cl-194/add-vertical-stepper-to-CL branch from dc81b4d to a9eb894 Compare June 5, 2025 13:49
@BryanCunningham BryanCunningham force-pushed the uif/cl-194/add-vertical-stepper-to-CL branch from a9eb894 to dad9be1 Compare June 5, 2025 15:41
@BryanCunningham BryanCunningham requested a review from vleague2 June 5, 2025 19:32
@BryanCunningham BryanCunningham marked this pull request as ready for review June 5, 2025 19:32
@BryanCunningham BryanCunningham requested a review from a team as a code owner June 5, 2025 19:32
Copy link

sonarqubecloud bot commented Jun 6, 2025

@BryanCunningham BryanCunningham merged commit 3e4c37b into main Jun 6, 2025
98 checks passed
@BryanCunningham BryanCunningham deleted the uif/cl-194/add-vertical-stepper-to-CL branch June 6, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants