-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CL-194] add vertical stepper to CL #14528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14528 +/- ##
==========================================
- Coverage 36.77% 36.75% -0.03%
==========================================
Files 3201 3208 +7
Lines 92661 92701 +40
Branches 13931 13934 +3
==========================================
- Hits 34076 34068 -8
- Misses 57179 57227 +48
Partials 1406 1406 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts! Also, looks like Storybook has an error for the vertical stepper story
libs/components/src/vertical-stepper/vertical-step-content.component.html
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-step-content.component.html
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-step-content.component.ts
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-step-content.component.ts
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-stepper.component.ts
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-stepper.stories.ts
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-stepper.stories.ts
Outdated
Show resolved
Hide resolved
e4d0e56
to
9bcea9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the idea of renaming this bit-stepper
, bit-step
, etc with a default input of orientation="vertical"
.
Seems appropriate if we adding a horizontal variant and we expect it to have the same API shape (right?).
libs/components/src/vertical-stepper/vertical-step-content.component.html
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-stepper.component.html
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-step.component.ts
Outdated
Show resolved
Hide resolved
libs/components/src/vertical-stepper/vertical-stepper.component.ts
Outdated
Show resolved
Hide resolved
4b7a6b2
to
f338037
Compare
362caf2
to
3fdda09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly questions lol
libs/components/src/resize-observer/resize-observer.directive.ts
Outdated
Show resolved
Hide resolved
e173335
to
e10303d
Compare
dc81b4d
to
a9eb894
Compare
a9eb894
to
dad9be1
Compare
Co-authored-by: Vicki League <[email protected]>
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/CL-194
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes