Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

Release/4.1.6 #433

Merged
merged 39 commits into from
Jun 23, 2017
Merged

Release/4.1.6 #433

merged 39 commits into from
Jun 23, 2017

Conversation

ElektrojungeAtWork
Copy link
Contributor

No description provided.

Benjamin Scholtysik (Reimold) and others added 30 commits May 1, 2017 11:18
…only-build

Disable Metrics config flag in crashonly builds
…r-xamarin-environment

Improve error logging to make sure we don’t log an error in case we r…
Undo changes related to Xamarin SDK fixes
new Xcode default warnings complains about missing voids
in function prototypes.
This hopefully fixes a CI failure for the Distribution target
Travis moved to 10.3.1, hence our required destinations now don't exist anymore.
Remove manual unlinking of Carthage on Travis
Send batch when application did enter background
Quick fix of translation as suggested by Vinicius Depizzol
Copy link
Contributor

@matthiaswenz matthiaswenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with some minor additions.

README.md Outdated

- `HockeySDK.framework` (except if you build a dynamic framework version of the SDK yourself!)
- `de.bitstadium.HockeySDK-iOS-4.1.5.docset`
It is super easy to use HockeyApp in your iOS app. Have a look at our [documentation]() and onboard your app within minutes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a link URL here?

README.md Outdated

* Mac running the latest version of OS X
* Get the latest Xcode from the Mac App Store
* A mac running the latest version of OS X.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple calls it "Mac"

README.md Outdated

If you have further questions or are running into trouble that cannot be resolved by any of the steps here, feel free to open a Github issue here, contact us at [[email protected]](mailto:[email protected]) or join our [Slack](https://slack.hockeyapp.net) [![Slack Status](https://slack.hockeyapp.net/badge.svg)](https://slack.hockeyapp.net)
If you have further questions or are running into trouble that cannot be resolved by any of the steps here, feel free to open a Github issue here, contact us at [[email protected]](mailto:[email protected]) or join our [Slack](https://slack.hockeyapp.net).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GitHub"

@@ -217,16 +246,22 @@ pod "HockeySDK"

#### 3.2.1 Binary Distribution Options

The default and recommended distribution is a binary (static library) and a resource bundle with translations and images for all SDK Features: Crash Reporting, User Feedback, Store Updates, Authentication, AdHoc Updates.
The default and recommended distribution is a binary (static library) and a resource bundle with translations and images for all SDK Features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: "features"


You must sign a [Contributor License Agreement](https://cla.microsoft.com/) before submitting your pull request. To complete the Contributor License Agreement (CLA), you will need to submit a request via the [form](https://cla.microsoft.com/) and then electronically sign the CLA when you receive the email containing the link to the document. You need to sign the CLA only once to cover submission to any Microsoft OSS project.

<a id="contact"></a>
## 7. Contact

If you have further questions or are running into trouble that cannot be resolved by any of the steps here, feel free to open a Github issue here, contact us at [[email protected]](mailto:[email protected]) or join our [Slack](https://slack.hockeyapp.net) [![Slack Status](https://slack.hockeyapp.net/badge.svg)](https://slack.hockeyapp.net)
If you have further questions or are running into trouble that cannot be resolved by any of the steps here, feel free to open a Github issue here, contact us at [[email protected]](mailto:[email protected]) or join our [Slack](https://slack.hockeyapp.net).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GitHub"

Copy link
Contributor

@matthiaswenz matthiaswenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ElektrojungeAtWork ElektrojungeAtWork merged commit ababf15 into master Jun 23, 2017
@ElektrojungeAtWork ElektrojungeAtWork deleted the release/4.1.6 branch June 23, 2017 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants