Skip to content

[BWS] feat(templates): removes horizontal rule from emails #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahume
Copy link
Contributor

@mahume mahume commented Jul 31, 2025

Changes

  • Removes the line between the header copy and description copy for incoming and outgoing transaction email templates for all supported languages.
  • formats to add a newline to the eof

Testing notes for reviewer

  1. Ensure dependencies are up to date in bitcore repo: npm install
  2. run Bitcore Wallet Service locally in /packages/bitcore-wallet-service
npm start && tail -f logs/bws.log
  1. Navigate to bitcore/packages/bitcore-wallet-service/src/scripts in a new tab
  2. Run each of the following scripts individually with your email:
node preview-email.js new_incoming_tx en send [email protected]
node preview-email.js new_incoming_tx es send [email protected]
node preview-email.js new_incoming_tx fr send [email protected]
node preview-email.js new_incoming_tx ja send [email protected]

node preview-email.js new_outgoing_tx en send [email protected]
node preview-email.js new_outgoing_tx es send [email protected]
node preview-email.js new_outgoing_tx fr send [email protected]
node preview-email.js new_outgoing_tx ja send [email protected]
  1. A new browser window will open with the preview.
  2. The <hr/> should be removed

- removes <hr> from incoming & outgoing transaction email templates for
all supported languages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant