Embedded bcoin node stability improvements #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nitsujlangston
commented
Aug 9, 2017
nitsujlangston
commented
- making embedded bcoin sync persistent
- correctly shutdown embedded bcoin instance
- wait until bcoin is listening on P2P before trying to connect
- align bcoin port and peer port
* correctly shutdown embedded bcoin instance * wait until bcoin is listening on P2P before trying to connect * align bcoin port and peer port
nitsujlangston
requested review from
kleetus,
bitjson,
gabegattis and
tenthirtyone
|
@nitsujlangston Sec, got through it |
simpler connect handling
tenthirtyone
reviewed
Aug 9, 2017
| self._initCache(); | ||
| self._initPool(); | ||
| self._setListeners(); | ||
| callback(); |
There was a problem hiding this comment.
startBcoinIfNec...
I think the callback on 116 here may be unnecessary. Any function passed through will executed after Bcoin finishes syncing and 'full' is fired. But the cb does not take any parameters. I can see:
() => { console.log('finished') };
working here. But what were your thoughts?
That said, this is benign and I am unable to tell what is going on in the scaffolding that could be passing a CB here or what its significance would be
| @@ -126,6 +125,9 @@ P2P.prototype._disconnectPool = function() { | |||
| }; | |||
|
|
|||
| P2P.prototype.stop = function(callback) { | |||
| if (this._bcoin){ | |||
| return this._bcoin.stop(callback); | |||
There was a problem hiding this comment.
Bcoin.stop does not accept any parameters.
lib/services/p2p/index.js
Outdated
| log.info('Connecting to p2p network.'); | ||
| this._pool.connect(); | ||
| self._pool.connect(); | ||
| var retryInterval = setInterval(function() { |
There was a problem hiding this comment.
Is it possible to drop this polling if self._pool.connect() were added to the Bcoin start callback?
…BcoinStartupHandling
…BcoinStartupHandling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.