Skip to content

[bitnami/thanos] Fix default value for ruler.alertmanagersconfig #32812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kir4h
Copy link
Contributor

@kir4h kir4h commented Apr 4, 2025

Description of the change

This PR changes the default value for ruler.alertmanagersConfig to be a map instead of a string for consistency with its documentation.

Benefits

When following the documentation, Helm will not issue the following warning when setting the variable.

coalesce.go:301: warning: destination for thanos.ruler.alertmanagersConfig is a table. Ignoring non-table value ()
coalesce.go:301: warning: destination for thanos.ruler.alertmanagersConfig is a table. Ignoring non-table value ()

Possible drawbacks

For users already using a string, a warning will now show up

coalesce.go:298: warning: cannot overwrite table with non table for thanos.ruler.alertmanagersConfig (map[])
coalesce.go:298: warning: cannot overwrite table with non table for thanos.ruler.alertmanagersConfig (map[])

Applicable issues

N/A

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
kir4h Andrés Álvarez
Signed-off-by: Andres Alvarez <[email protected]>
@github-actions github-actions bot added the triage Triage is needed label Apr 4, 2025
@github-actions github-actions bot requested a review from carrodher April 4, 2025 08:09
@github-actions github-actions bot added the thanos label Apr 4, 2025
Signed-off-by: Bitnami Bot <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Apr 7, 2025
@github-actions github-actions bot removed the triage Triage is needed label Apr 7, 2025
@github-actions github-actions bot removed the request for review from carrodher April 7, 2025 10:43
@github-actions github-actions bot requested a review from dgomezleon April 7, 2025 10:43
Signed-off-by: Bitnami Bot <[email protected]>
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@dgomezleon dgomezleon merged commit 2e66e3e into bitnami:main Apr 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved thanos verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants