Skip to content

[bitnami/redis-cluster] Set usePasswordFiles=true by default #32118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 7, 2025

Conversation

migruiz4
Copy link
Member

Description of the change

Sets default value for usePasswordFiles to true.

Benefits

With this change, the chart will mount the secrets as files by default instead of directly setting them into environment variables.

Possible drawbacks

None

Applicable issues

None

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Signed-off-by: Miguel Ruiz <[email protected]>
@github-actions github-actions bot added redis-cluster verify Execute verification workflow for these changes bitnami labels Feb 21, 2025
@github-actions github-actions bot requested a review from fmulero February 21, 2025 11:52
Bitnami Containers added 2 commits February 21, 2025 11:56
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those users who set the old value usePasswordFile to false, I'd add an entry in the Upgrading README section to mention this change, because the expected behaviour will be different.

Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Mar 15, 2025
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Mar 21, 2025
@carrodher carrodher deleted the password-files-redis-cluster branch March 25, 2025 18:17
@migruiz4 migruiz4 restored the password-files-redis-cluster branch April 4, 2025 10:12
@migruiz4 migruiz4 reopened this Apr 4, 2025
@github-actions github-actions bot removed the solved label Apr 4, 2025
Signed-off-by: Miguel Ruiz <[email protected]>
bitnami-bot and others added 2 commits April 4, 2025 10:16
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
alvneiayu
alvneiayu previously approved these changes Apr 4, 2025
@github-actions github-actions bot removed the stale 15 days without activity label Apr 5, 2025
Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
@migruiz4 migruiz4 merged commit 2e2ac61 into main Apr 7, 2025
12 checks passed
@migruiz4 migruiz4 deleted the password-files-redis-cluster branch April 7, 2025 15:02
@github-actions github-actions bot added the solved label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami redis-cluster solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants